Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

formats/fmp4: improve unmarshaler performance #112

Merged
merged 1 commit into from Mar 17, 2024
Merged

formats/fmp4: improve unmarshaler performance #112

merged 1 commit into from Mar 17, 2024

Conversation

aler9
Copy link
Member

@aler9 aler9 commented Mar 17, 2024

No description provided.

Copy link

codecov bot commented Mar 17, 2024

Codecov Report

Attention: Patch coverage is 63.48837% with 157 lines in your changes are missing coverage. Please review.

Project coverage is 84.29%. Comparing base (f276ff6) to head (3706cb2).

Files Patch % Lines
pkg/formats/fmp4/init.go 60.25% 85 Missing and 39 partials ⚠️
pkg/formats/fmp4/parts.go 72.03% 22 Missing and 11 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #112      +/-   ##
==========================================
- Coverage   84.73%   84.29%   -0.44%     
==========================================
  Files          72       72              
  Lines        5619     5635      +16     
==========================================
- Hits         4761     4750      -11     
- Misses        639      657      +18     
- Partials      219      228       +9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@aler9 aler9 merged commit 059a8bc into main Mar 17, 2024
6 of 8 checks passed
@aler9 aler9 deleted the feature/perf branch March 17, 2024 22:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant