Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

webrtc: fix crash in case of errors during PATCH (#2609) #2613

Merged
merged 1 commit into from Oct 30, 2023

Conversation

aler9
Copy link
Member

@aler9 aler9 commented Oct 30, 2023

Fixes #2609

@codecov
Copy link

codecov bot commented Oct 30, 2023

Codecov Report

Merging #2613 (43625cc) into main (4b4d57f) will decrease coverage by 0.02%.
Report is 2 commits behind head on main.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main    #2613      +/-   ##
==========================================
- Coverage   60.02%   60.00%   -0.02%     
==========================================
  Files         145      145              
  Lines       15531    15536       +5     
==========================================
  Hits         9322     9322              
- Misses       5569     5572       +3     
- Partials      640      642       +2     
Files Coverage Δ
internal/core/webrtc_http_server.go 69.45% <0.00%> (ø)

... and 4 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@aler9 aler9 merged commit ecee2af into main Oct 30, 2023
6 of 8 checks passed
@aler9 aler9 deleted the bug/webrtc-crash branch October 30, 2023 18:53
Copy link
Contributor

This issue is mentioned in release v1.3.0 🚀
Check out the entire changelog by clicking here

@aler9 aler9 mentioned this pull request Dec 18, 2023
13 tasks
@github-actions github-actions bot locked and limited conversation to collaborators May 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

App crashing then publish to RTSP and receive from WebRTC
1 participant