HLS.js usage: bugfix, stability improvements and resilience improvement #2631
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #2631 +/- ##
==========================================
- Coverage 59.30% 59.29% -0.01%
==========================================
Files 144 144
Lines 15228 15228
==========================================
- Hits 9031 9030 -1
- Misses 5561 5562 +1
Partials 636 636 see 3 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
aler9
requested changes
Nov 2, 2023
…l-error - STABILITY: await MEDIA_ATTACHED event before performing "loadSource" on HLS - STABILITY: await MANIFEST_PARSED event before performing "play" on video element - RESILIENCE: on "MEDIA_ERROR" event perform "recoverMediaError" on HLS
|
Code was now adjusted. |
aler9
approved these changes
Nov 3, 2023
|
merged, thanks |
aler9
added a commit
that referenced
this pull request
Jan 28, 2024
when a player received a stream with incompatible codecs, it started polling the server for index.m3u8 in an infinite loop. This was caused by #2631
|
This issue is mentioned in release v1.5.1 🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I propose the following changes to the HLS.js: