Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add query as optional block for SRT publish and read #2656

Merged
merged 1 commit into from Nov 16, 2023

Conversation

bcherniakh
Copy link
Contributor

Illustrates solution 1 for #2654

Copy link

codecov bot commented Nov 7, 2023

Codecov Report

Merging #2656 (61d17d8) into main (5dae270) will decrease coverage by 0.08%.
The diff coverage is 57.89%.

@@            Coverage Diff             @@
##             main    #2656      +/-   ##
==========================================
- Coverage   59.41%   59.33%   -0.08%     
==========================================
  Files         144      144              
  Lines       15238    15248      +10     
==========================================
- Hits         9053     9047       -6     
- Misses       5549     5560      +11     
- Partials      636      641       +5     
Files Coverage Δ
internal/core/srt_conn.go 75.70% <57.89%> (-0.52%) ⬇️

... and 5 files with indirect coverage changes

📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today!

@aler9 aler9 merged commit 4fa6c16 into bluenviron:main Nov 16, 2023
6 of 8 checks passed
@aler9
Copy link
Member

aler9 commented Nov 16, 2023

Hello, yes, this is a good way to provide the query feature to the SRT protocol too. Merged, thanks.

Copy link
Contributor

This issue is mentioned in release v1.3.1 🚀
Check out the entire changelog by clicking here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants