Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

webrtc: improve connectivity mechanism #2686

Merged
merged 1 commit into from Nov 12, 2023
Merged

webrtc: improve connectivity mechanism #2686

merged 1 commit into from Nov 12, 2023

Conversation

aler9
Copy link
Member

@aler9 aler9 commented Nov 12, 2023

  • add webrtcAdditionalHosts and allow to use DNS names in place of IPs
  • always use a fixed UDP port
  • allow to disable UDP
  • do not use a STUN server by default

Copy link

codecov bot commented Nov 12, 2023

Codecov Report

Merging #2686 (5c6e445) into main (4cf8948) will decrease coverage by 0.13%.
Report is 1 commits behind head on main.
The diff coverage is 58.46%.

@@            Coverage Diff             @@
##             main    #2686      +/-   ##
==========================================
- Coverage   59.53%   59.41%   -0.13%     
==========================================
  Files         144      144              
  Lines       15291    15315      +24     
==========================================
- Hits         9104     9099       -5     
- Misses       5548     5575      +27     
- Partials      639      641       +2     
Files Coverage Δ
internal/conf/encryption.go 26.66% <ø> (ø)
internal/core/path.go 64.06% <ø> (+0.23%) ⬆️
internal/core/core.go 85.67% <96.42%> (-0.07%) ⬇️
internal/protocols/webrtc/whip_client.go 0.00% <0.00%> (ø)
internal/core/webrtc_manager.go 62.86% <82.00%> (-0.46%) ⬇️
internal/conf/conf.go 62.57% <33.33%> (-2.61%) ⬇️
internal/protocols/webrtc/api.go 0.00% <0.00%> (ø)

... and 3 files with indirect coverage changes

📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today!

@aler9 aler9 merged commit 687d868 into main Nov 12, 2023
6 checks passed
@aler9 aler9 deleted the feature/webrtc-passive branch November 12, 2023 22:55
Copy link
Contributor

This issue is mentioned in release v1.3.0 🚀
Check out the entire changelog by clicking here

@github-actions github-actions bot locked and limited conversation to collaborators May 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant