Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

webrtc: fix propagating query parameters when appending slash to paths #2771

Merged
merged 1 commit into from Dec 1, 2023

Conversation

aler9
Copy link
Member

@aler9 aler9 commented Dec 1, 2023

No description provided.

Copy link

codecov bot commented Dec 1, 2023

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (0e5e332) 59.66% compared to head (750d04f) 59.62%.

Files Patch % Lines
internal/core/webrtc_http_server.go 40.00% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2771      +/-   ##
==========================================
- Coverage   59.66%   59.62%   -0.05%     
==========================================
  Files         142      142              
  Lines       15178    15182       +4     
==========================================
- Hits         9056     9052       -4     
- Misses       5485     5492       +7     
- Partials      637      638       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@aler9 aler9 merged commit 4ccb245 into main Dec 1, 2023
6 of 8 checks passed
@aler9 aler9 deleted the bug/webrtc-slash branch December 1, 2023 19:24
Copy link
Contributor

This issue is mentioned in release v1.4.0 🚀
Check out the entire changelog by clicking here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant