Add Argon2 credential hash support #2888
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #2888 +/- ##
==========================================
+ Coverage 53.21% 53.40% +0.19%
==========================================
Files 124 124
Lines 11448 11497 +49
==========================================
+ Hits 6092 6140 +48
- Misses 4902 4905 +3
+ Partials 454 452 -2 ☔ View full report in Codecov by Sentry. |
|
Hello, thank you very much for contributing this feature. I'll merge this in some days in order to allow me to review the PR and to allow you to push any further addition. |
|
merged, thanks! |
|
This issue is mentioned in release v1.5.0 🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pr proposes adding support for Argon2 besides SHA256 for credentials.
Argon2 seems to be widely used and is the recommended way of storing passwords by owasp at the moment.
To support both argon2 and sha256, I've moved some of the validation logic into the Credential struct. This way the rest of the codebase doesn't need an understanding o the different configuration options.