Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

srt: support standard streamID syntax (#2469) #2919

Merged
merged 1 commit into from Jan 18, 2024
Merged

Conversation

aler9
Copy link
Member

@aler9 aler9 commented Jan 18, 2024

Fixes #2469

Copy link

codecov bot commented Jan 18, 2024

Codecov Report

Attention: 40 lines in your changes are missing coverage. Please review.

Comparison is base (397c58a) 53.40% compared to head (e5801a8) 51.40%.
Report is 7 commits behind head on main.

Files Patch % Lines
internal/servers/srt/conn.go 0.00% 22 Missing ⚠️
internal/servers/srt/streamid.go 68.42% 16 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2919      +/-   ##
==========================================
- Coverage   53.40%   51.40%   -2.00%     
==========================================
  Files         124      128       +4     
  Lines       11497    12022     +525     
==========================================
+ Hits         6140     6180      +40     
- Misses       4905     5390     +485     
  Partials      452      452              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@aler9 aler9 merged commit b3eaec5 into main Jan 18, 2024
6 of 8 checks passed
@aler9 aler9 deleted the feature/srt-streamid branch January 18, 2024 22:23
Copy link
Contributor

This issue is mentioned in release v1.5.0 🚀
Check out the entire changelog by clicking here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow SRT access control syntax
1 participant