Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

record: use reception time instead of current time in segment names #2925

Merged
merged 1 commit into from Jan 21, 2024

Conversation

aler9
Copy link
Member

@aler9 aler9 commented Jan 21, 2024

No description provided.

Copy link

codecov bot commented Jan 21, 2024

Codecov Report

Attention: 24 lines in your changes are missing coverage. Please review.

Comparison is base (f8a56aa) 51.22% compared to head (13d3073) 51.28%.

Files Patch % Lines
internal/record/format_fmp4.go 25.92% 20 Missing ⚠️
internal/record/format_mpegts.go 81.81% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2925      +/-   ##
==========================================
+ Coverage   51.22%   51.28%   +0.06%     
==========================================
  Files         128      128              
  Lines       12079    12103      +24     
==========================================
+ Hits         6187     6207      +20     
- Misses       5441     5445       +4     
  Partials      451      451              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@aler9 aler9 changed the title record: use time of packets instead of current time in segment names record: use reception time instead of current time in segment names Jan 21, 2024
@aler9 aler9 merged commit 9b270ad into main Jan 21, 2024
8 checks passed
@aler9 aler9 deleted the feature/record-ntp branch January 21, 2024 18:15
Copy link
Contributor

This issue is mentioned in release v1.5.0 🚀
Check out the entire changelog by clicking here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant