Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

playback: increase sequence number of fMP4 parts #3200

Merged
merged 1 commit into from Apr 7, 2024
Merged

Conversation

aler9
Copy link
Member

@aler9 aler9 commented Apr 7, 2024

No description provided.

@aler9 aler9 changed the title Fix/playback seqnum playback: increase sequence number of fMP4 parts Apr 7, 2024
Copy link

codecov bot commented Apr 7, 2024

Codecov Report

Attention: Patch coverage is 82.75862% with 20 lines in your changes are missing coverage. Please review.

Project coverage is 55.73%. Comparing base (b64e082) to head (d25aef9).

Files Patch % Lines
internal/playback/muxer_fmp4.go 79.72% 9 Missing and 6 partials ⚠️
internal/playback/segment_fmp4.go 78.26% 2 Missing and 3 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3200      +/-   ##
==========================================
- Coverage   55.73%   55.73%   -0.01%     
==========================================
  Files         153      154       +1     
  Lines       16902    16917      +15     
==========================================
+ Hits         9421     9429       +8     
- Misses       6739     6743       +4     
- Partials      742      745       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@aler9 aler9 merged commit 0a8e626 into main Apr 7, 2024
8 checks passed
@aler9 aler9 deleted the fix/playback-seqnum branch April 7, 2024 12:23
Copy link
Contributor

This issue is mentioned in release v1.7.0 🚀
Check out the entire changelog by clicking here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant