Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

webrtc: return 404 in case a WHIP PATCH or WHIP DELETE request fails #3232

Merged
merged 1 commit into from Apr 13, 2024

Conversation

aler9
Copy link
Member

@aler9 aler9 commented Apr 13, 2024

No description provided.

Copy link

codecov bot commented Apr 13, 2024

Codecov Report

Attention: Patch coverage is 40.00000% with 6 lines in your changes are missing coverage. Please review.

Project coverage is 56.08%. Comparing base (4354535) to head (c661d59).

Files Patch % Lines
internal/servers/webrtc/http_server.go 40.00% 4 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3232      +/-   ##
==========================================
+ Coverage   56.01%   56.08%   +0.07%     
==========================================
  Files         154      154              
  Lines       17036    17042       +6     
==========================================
+ Hits         9542     9558      +16     
+ Misses       6741     6734       -7     
+ Partials      753      750       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@aler9 aler9 merged commit a6cc52f into main Apr 13, 2024
7 of 8 checks passed
@aler9 aler9 deleted the fix/webrtc-404 branch April 13, 2024 09:04
Copy link
Contributor

This issue is mentioned in release v1.7.0 🚀
Check out the entire changelog by clicking here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant