Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

webrtc, hls: use absolute paths in Location header (#3195) (#3177) #3240

Merged
merged 1 commit into from Apr 14, 2024

Conversation

aler9
Copy link
Member

@aler9 aler9 commented Apr 14, 2024

Fixes #3177

Copy link

codecov bot commented Apr 14, 2024

Codecov Report

Attention: Patch coverage is 40.74074% with 32 lines in your changes are missing coverage. Please review.

Project coverage is 56.03%. Comparing base (a18bebf) to head (a7eaa17).

Files Patch % Lines
internal/protocols/webrtc/whip_client.go 0.00% 20 Missing ⚠️
internal/servers/hls/http_server.go 0.00% 7 Missing ⚠️
internal/servers/webrtc/http_server.go 80.00% 2 Missing and 3 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3240      +/-   ##
==========================================
- Coverage   56.09%   56.03%   -0.06%     
==========================================
  Files         150      149       -1     
  Lines       17042    17043       +1     
==========================================
- Hits         9559     9550       -9     
- Misses       6733     6742       +9     
- Partials      750      751       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@aler9 aler9 mentioned this pull request Apr 14, 2024
12 tasks
@aler9 aler9 merged commit 665e11a into main Apr 14, 2024
6 of 8 checks passed
@aler9 aler9 deleted the fix/absolute-path branch April 14, 2024 10:04
Copy link
Contributor

This issue is mentioned in release v1.7.0 🚀
Check out the entire changelog by clicking here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

WHIP/WHEP: DELETE not properly handled
1 participant