Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature request(snap/flatpak) #65

Closed
Lvaskz opened this issue Oct 16, 2020 · 24 comments
Closed

feature request(snap/flatpak) #65

Lvaskz opened this issue Oct 16, 2020 · 24 comments
Labels
Fix Released The fix was released.

Comments

@Lvaskz
Copy link

Lvaskz commented Oct 16, 2020

Hi, see title above.

@TheEvilSkeleton
Copy link
Contributor

I agree. I'd love to see this.

@TheEvilSkeleton
Copy link
Contributor

TheEvilSkeleton commented Nov 1, 2020

@Lvaskz what are your thoughts on us working together to get it to work as a flatpak? I wouldn't mind giving it a try.

@Lvaskz
Copy link
Author

Lvaskz commented Nov 2, 2020

Hi, I am not developer, but I made flatPak app request, here you are in the right place to see menulibre as flatPak https://discourse.flathub.org/t/menulibre-request-flatpak/870
Can you help?

@TheEvilSkeleton
Copy link
Contributor

TheEvilSkeleton commented Dec 23, 2020

Sorry for the late response. I haven't gotten any notifications from this.

I'll try to do what I can.

@TheEvilSkeleton
Copy link
Contributor

Okay, so I initialized the manifest: https://github.com/TheEvilSkeleton/flatpaks/blob/org.bluesabre.MenuLibre/org.bluesabre.MenuLibre.yaml

The program launched! Only thing I now have to do is try to get it to work, since it doesn't look through application files.

@TheEvilSkeleton
Copy link
Contributor

@bluesabre I hope you don't mind the ping. Is there a way to make MenuLibre search inside /run/host/ as well? Since flatpaks are completely sandboxed, host commands are unavailable inside the flatpak, they are mounted in /run/host/. For example, /usr/bin/flatpak in host will be in /run/host/usr/bin/flatpak inside the flatpak.

/run/host/usr/bin/flatpak cannot be executed, that's why I'd like to ask if it can just be found.

@Lvaskz
Copy link
Author

Lvaskz commented Jan 20, 2021

Appeditor has the same problem, well I don't know if some other package as appimage or snap will be more convenient for that.

@TheEvilSkeleton
Copy link
Contributor

TheEvilSkeleton commented Jan 20, 2021

Maybe a patch to check inside /run/host/ as well? This is the only thing missing currently, since the program itself works, but it doesn't check host commands.

@bluesabre
Copy link
Owner

@TheEvilSkeleton Sorry for the delay on this! I'll work on getting this added over the weekend.

@TheEvilSkeleton
Copy link
Contributor

@bluesabre awesome. Just a little tip: you can fork my flatpaks repo and update the manifest, and then submit a merge request to https://github.com/flathub/flathub, since I've written most of the manifest already.

@bluesabre
Copy link
Owner

@TheEvilSkeleton @Lvaskz Thanks for the help here. I think I've got it all working with the below PR if you want to test it out.

#73

@TheEvilSkeleton
Copy link
Contributor

TheEvilSkeleton commented Feb 20, 2021

@bluesabre good news and bad news. The good news is that MenuLibre doesn''t complain about flatpak not being available:

After

image

Before

image

The bad news is that the flatpaks don't show up in MenuLibre.


TheEvilSkeleton/flatpaks@c034ae3


If you want to try out the flatpak, assuming you have the flathub repository added and flatpak-builder installed, run the following commands:

git clone https://github.com/TheEvilSkeleton/flatpaks
cd flatpaks
git checkout org.bluesabre.MenuLibre
flatpak-builder --force-clean --install-deps-from=flathub --install build-dir org.bluesabre.MenuLibre

@TheEvilSkeleton
Copy link
Contributor

@bluesabre I just tried to change a bit in the manifest, but all of them failed to see the Flatpak packages. I really don't know what to do now.

@bluesabre
Copy link
Owner

@TheEvilSkeleton I took another crack at it. However, I'm starting to get the feeling that the sandboxed nature of flatpaks is what's actually preventing them from being displayed. I also experimented with another flatpak'd app editor, but it doesn't list flatpaks either.

@TheEvilSkeleton
Copy link
Contributor

@bluesabre I gave the Flatpak package rw access to ~/.local/share/flatpak/ (https://github.com/TheEvilSkeleton/flatpaks/blob/org.bluesabre.MenuLibre/org.bluesabre.MenuLibre.yaml#L14) and added it to the XDG_DATA_DIRS and PATH. That is all I can do to be honest.

I guess the most we can do is ask help in #flatpak on freenode? I don't know how to code, so I cannot help much.

@Lvaskz
Copy link
Author

Lvaskz commented Jul 14, 2021

Hi,

Appeditor has the same problem, well I don't know if some other package as appimage or snap will be more convenient for that.

here some information for changing mind. Appimage has not that issue, I guess
https://github.com/AppImageCrafters/appimage-builder

@sonnyp
Copy link

sonnyp commented Oct 28, 2021

I ran into a similar problem with my app, here is the workaround for flatpak

flathub/re.sonny.Junction@f48f522

@TheEvilSkeleton
Copy link
Contributor

@sonnyp you're a godsend, thanks a lot!

@sonnyp
Copy link

sonnyp commented Oct 30, 2021

😊

One thing I forgot to mention is that it would make menulibre even better as it will list desktop entries with broken executables - allowing the user to delete or fix them.

@TheEvilSkeleton
Copy link
Contributor

TheEvilSkeleton commented Oct 30, 2021

One thing I forgot to mention is that it would make menulibre even better as it will list desktop entries with broken executables - allowing the user to delete or fix them.

Hmm... it only found some invalid desktop entries, not all of them.

The rest seems to work well. I was able to edit apps without a problem and it does its job.

@bluesabre is it okay if I submit an MR in the Flathub repo so we can start making some bundles and test?

@bluesabre
Copy link
Owner

@TheEvilSkeleton Definitely, please do!

@sonnyp
Copy link

sonnyp commented Oct 30, 2021

Hmm... it only found some invalid desktop entries, not all of them.

You might want to patch further to disable checks for OnlyShowIn / NotShowIn / NoDisplay and Hidden but that's something else.

@TheEvilSkeleton
Copy link
Contributor

Hmm... it only found some invalid desktop entries, not all of them.

You might want to patch further to disable checks for OnlyShowIn / NotShowIn / NoDisplay and Hidden but that's something else.

I confess, I'm not a programmer 😅 so I don't know what these are. I just enjoy creating Flatpak manifests.

@TheEvilSkeleton
Copy link
Contributor

This can be closed: https://flathub.org/apps/details/org.bluesabre.MenuLibre!

@bluesabre bluesabre added the Fix Released The fix was released. label Sep 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Fix Released The fix was released.
Projects
None yet
Development

No branches or pull requests

4 participants