Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Entryway PDS resolves handles after account migration #2280

Open
Tracked by #381
goeo- opened this issue Mar 6, 2024 · 7 comments
Open
Tracked by #381

Entryway PDS resolves handles after account migration #2280

goeo- opened this issue Mar 6, 2024 · 7 comments
Labels
bug Something isn't working

Comments

@goeo-
Copy link

goeo- commented Mar 6, 2024

Describe the bug

I migrated my account did:plc:f5ejbog3ostso47er2y5ugbl to my own pds, then changed the handle to on-plc.goeo.lol. That account has held the handle genco.me before.

I even deactivated the account on the bluesky servers, but when I resolveHandle genco.me on bsky.social, it still resolves to my old did:plc.

To Reproduce

Steps to reproduce the behavior:

  1. https://bsky.social/xrpc/com.atproto.identity.resolveHandle?handle=genco.me
  2. https://bsky-debug.app/handle?handle=genco.me

Expected behavior

Nothing should be resolving genco.me as anything but did:web:genco.me.

@goeo- goeo- added the bug Something isn't working label Mar 6, 2024
@goeo-
Copy link
Author

goeo- commented Mar 24, 2024

i'd like to try to fix this, but it's unclear what software the entryway runs (some branch?) - i think this effects all migrated accounts, and is still causing problems like https://bsky.app/profile/mackuba.eu/post/3kofkqrqiez2l

@snarfed
Copy link
Contributor

snarfed commented Apr 15, 2024

I think I'm seeing this issue too, with accounts on my third party federated PDS.

@snarfed.indieweb.social.ap.brid.gy is an example: the first time you load eg https://bsky.app/profile/snarfed.indieweb.social.ap.brid.gy , it shows an Oops! Unable to resolve handle error. Behind the scenes, it's hitting https://bsky.social/xrpc/com.atproto.identity.resolveHandle?handle=snarfed.indieweb.social.ap.brid.gy , which always 400s with Unable to resolve handle. When I click Try again, it hits https://morel.us-east.host.bsky.network/xrpc/com.atproto.identity.resolveHandle?handle=snarfed.indieweb.social.ap.brid.gy , which correctly returns that account's DID, so the profile loads.

@goeo- this seems similar to what you're seeing. https://bsky.social/xrpc/com.atproto.identity.resolveHandle?handle=genco.me returns your old did:plc, but https://morel.us-east.host.bsky.network/xrpc/com.atproto.identity.resolveHandle?handle=genco.me correctly returns did:web:genco.me.

@snarfed
Copy link
Contributor

snarfed commented Apr 15, 2024

^ thanks @mackuba for the great sleuthing!

@snarfed
Copy link
Contributor

snarfed commented Apr 25, 2024

bluesky-social/social-app#3620 hopefully fixes this, and it's merged, so the next entryway release should do it 🤞.

Than you @mary-ext!!!

@goeo-
Copy link
Author

goeo- commented Apr 25, 2024

i would leave the issue open until the entryway starts resolving my handle correctly, or removes the endpoint, but this should fix the problem, for sure!

@snarfed
Copy link
Contributor

snarfed commented May 2, 2024

Looks like this might be fixed...? Federated profiles are now all loading for me on bsky.app the first time!

@snarfed
Copy link
Contributor

snarfed commented May 2, 2024

...although @goeo- reports that this only seems fixed for federated did:plcs, not for did:webs like his. The client side PR doesn't fix the entryway's stale caching, it's just a band-aid that avoids it altogether.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants