Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Validate CIDs passed to PDS xrpc methods #456

Closed
devinivy opened this issue Jan 4, 2023 · 1 comment
Closed

Validate CIDs passed to PDS xrpc methods #456

devinivy opened this issue Jan 4, 2023 · 1 comment

Comments

@devinivy
Copy link
Collaborator

devinivy commented Jan 4, 2023

There are a handful of cid parameters and inputs to the PDS xrpc methods. We should consider validating these as CIDs, otherwise fail the request with a 400. In some cases currently CID.parse() may be called on them, causing an error to be thrown that turns into a 500.
@devinivy devinivy mentioned this issue Jan 4, 2023
Merged
@dholms
Copy link
Collaborator

dholms commented Apr 4, 2023

fixed w new cid format

#658

@dholms dholms closed this as completed Apr 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@devinivy @dholms