Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/gosky: plc flag not defined for didGet #12

Closed
karalabe opened this issue Feb 8, 2023 · 2 comments
Closed

cmd/gosky: plc flag not defined for didGet #12

karalabe opened this issue Feb 8, 2023 · 2 comments

Comments

@karalabe
Copy link

karalabe commented Feb 8, 2023

Can I haz:

		&cli.StringFlag{
			Name:    "plc",
			Value:   "https://plc.staging.bsky.dev",
			EnvVars: []string{"BSKY_PLC_URL"},
		},

in https://github.com/bluesky-social/indigo/blob/main/cmd/gosky/main.go#L155, otherwise https://github.com/bluesky-social/indigo/blob/main/cmd/gosky/util/util.go#L24 is a noop and the command goes boom

$ go run ./cmd/gosky did get @karalabe.bsky.social
Get "/@karalabe.bsky.social": unsupported protocol scheme ""
exit status 1
@whyrusleeping
Copy link
Collaborator

Resolved in 420c098

why@sirius ~/c/gosky (main)> ./gosky did get did:plc:ragtjsm2j2vknwkz3zp4oxrd
{
  "@context": [
    "https://www.w3.org/ns/did/v1",
    "https://w3id.org/security/suites/secp256k1-2019/v1"
  ],
  "id": "did:plc:ragtjsm2j2vknwkz3zp4oxrd",
  "alsoKnownAs": [
    "https://paul.bsky.social"
  ],
  "authentication": null,
  "verificationMethod": [
    {
      "id": "#signingKey",
      "type": "EcdsaSecp256k1VerificationKey2019",
      "controller": "did:plc:ragtjsm2j2vknwkz3zp4oxrd",
      "publicKeyMultibase": "zMy9mFCjiJvSfUoboTdFZV4n2sxq1JpUWT8Xxkt16gNhBf6oW3FurYQLAYDtThJXD1rHtWmugFCtrQqGoJk1x5PpK"
    },
    {
      "id": "#recoveryKey",
      "type": "EcdsaSecp256k1VerificationKey2019",
      "controller": "did:plc:ragtjsm2j2vknwkz3zp4oxrd",
      "publicKeyMultibase": "zNET4n9SXotP16s46Dg3GPdWCL2iqe6MDEQ9DsT1PeTVSQgegPm4MChUmQW3A87cqaiSPa29PYGcZoKUaRZYoN4Fc"
    }
  ],
  "service": [
    {
      "id": "#atpPds",
      "type": "AtpPersonalDataServer",
      "serviceEndpoint": "https://bsky.social"
    }
  ]
}

@whyrusleeping
Copy link
Collaborator

Thanks for the report :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants