Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: fixed fontFamily #7

Merged
merged 1 commit into from
Apr 26, 2024

Conversation

nakapon9517
Copy link
Contributor

@nakapon9517 nakapon9517 commented Apr 23, 2024

fixes #8

Fonts were not changed when using UITextView, even if specified in TextStyle's FontFamily.

<Text selectable uiTextView style={{fontFamily: 'Hiragino Sans'}}>
  Allow non-system fonts to be specified with fontFamily
</Text>

I am a newbie when it comes to contributions, but I am submitting a PR for react-native-uitextview because it is the ideal library I have been looking for.

I am not a Swift professional, so if there are any errors, I would appreciate it if you could let me know :)

@nakapon9517 nakapon9517 marked this pull request as ready for review April 23, 2024 09:56
Copy link
Member

@haileyok haileyok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool! Quick glance looks good, will test/merge later today. Appreciate it!

@haileyok haileyok merged commit 461c9d6 into bluesky-social:main Apr 26, 2024
@haileyok
Copy link
Member

Sorry, got busy the other day. Released it now, thank you again!

@nakapon9517
Copy link
Contributor Author

Thank you for taking the time to confirm this.

Thank you for your continued support!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement fontfamily
2 participants