Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DeviceCollector throws some exceptions away in tests that use it #39

Closed
rosesyrett opened this issue Oct 26, 2023 · 1 comment
Closed

DeviceCollector throws some exceptions away in tests that use it #39

rosesyrett opened this issue Oct 26, 2023 · 1 comment

Comments

@rosesyrett
Copy link
Collaborator

Recently, when writing a bit of code for blueapi (DiamondLightSource/blueapi#321) we found that if we tried to test the Device Collector (as per bluesky/ophyd#1151)

The tests in Callum's PR seem to fail for the original Device Collector if assert statements on the logs are present. This is odd behaviour and should be fixed.
@rosesyrett rosesyrett mentioned this issue Oct 26, 2023
Merged
@coretl
Copy link
Collaborator

coretl commented Apr 16, 2024

Fixed by #97

@coretl coretl closed this as completed Apr 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@rosesyrett @coretl