Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parametrized fixture regression in branch fixture-stack #365

Closed
oakkitten opened this issue Jun 4, 2020 · 2 comments
Closed

Parametrized fixture regression in branch fixture-stack #365

oakkitten opened this issue Jun 4, 2020 · 2 comments

Comments

@oakkitten
Copy link

as reported here and confirmed by my tests, branch fixture-stack runs a parametrized fixture a suboptimal amount of times.

running this example, output using current upstream master (5.4.1.dev422+gcf640a9b6, also 3.10.1 and some versions in between):

test_cats_dogs.py dog charlie
cat tom
.sssdog buddy
ss.scat simba
sss.dog charlie
s.ss

output from fixtue-stack:

test_cats_dogs.py dog charlie
cat tom
.sssdog buddy
cat tom
ss.scat simba
sss.dog charlie
cat simba
s.ss
@blueyed
Copy link
Owner

blueyed commented Jun 30, 2020

Thanks for the report. Should go into the discussion on/of the PR itself though: pytest-dev#6551.

(FYI: I do not plan to finish/work on this myself anytime soon in the pytest-dev/pytest project itself.)

@SalmonMode
Copy link

@blueyed as discussed on pytest-dev#7053, that is not a problem with the fixture-stack branch. That was a misunderstanding of the description of how pytest "optimizes" the fixtures it runs. I will remake the branch and take over the work again though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants