Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deleting confirmation dialog #233

Open
EwelinaSkrzypacz opened this issue Sep 23, 2022 · 1 comment
Open

Deleting confirmation dialog #233

EwelinaSkrzypacz opened this issue Sep 23, 2022 · 1 comment
Labels
feature new feature to implement

Comments

@EwelinaSkrzypacz
Copy link
Member

Some resource can be deleted - benefits, CV, technologies, keys, holidays. It will be nice to add for them deleting confirmation dialog.

@EwelinaSkrzypacz EwelinaSkrzypacz added the feature new feature to implement label Sep 23, 2022
@EwelinaSkrzypacz EwelinaSkrzypacz self-assigned this Sep 7, 2023
@EwelinaSkrzypacz
Copy link
Member Author

After a research I think that we don't need confirmation modals itself. Confirmation dialogue modals appear after users take significant actions to ensure they are aware of the consequences.

In our application, the user (with right permissions) can delete benefits, CV, technologies, keys and holidays. Deleting these resources don't have big consequences - maybe accidentally deleting filled CV is sad, but only this.

Alternatively, some systems offer an "undo" feature instead of a confirmation, presented as a temporary notification that doesn't demand extra user attention. For instance, Google Gmail provides an undo option after deleting e-mail message.

image

And I think it will be great thing in the app. But it is harder that add modals, so it needs some vision how to implement this. So for now I leave this task for the future.

@EwelinaSkrzypacz EwelinaSkrzypacz removed their assignment Sep 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature new feature to implement
Projects
None yet
Development

No branches or pull requests

1 participant