Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Immediate "To Do" Items (Oct.26th) #3

Closed
who-biz opened this issue Oct 26, 2019 · 1 comment
Closed

Immediate "To Do" Items (Oct.26th) #3

who-biz opened this issue Oct 26, 2019 · 1 comment
Labels
resolved dun been resolutioned

Comments

@who-biz
Copy link
Contributor

who-biz commented Oct 26, 2019

1.) Add idle handler for cleaning pending ntzpool. There should not be two pending ntz's in the pool at a given time. Should be simple enough to write in some extra rules to the refresh or update_pool RPC calls. Done : 2 Nov

2.) Existing idle handler needs to properly fetch pending ntz from the pool w/ metadata rather than relaying a NOTIFY_REQUEST_NTZ_SIG unconditionally.
Done: 30 Oct

3.) Make sure that invalid signature error has been cleared up. (follow-up on e15fecc)
- Also clean up the existing res.tx_metadata_list response that is fed into a request_ntz_sig wallet call. We really shouldn't need to handle the metadata list as a list, and should be able to change this to a string. It is one contiguous hex blob currently, so a list with one element.
Done: 30 Oct

4.) Make sure that what is being done with checking the identity element & viewkeys is acceptable means for verifying sender is a notary node. This might not be a sufficient check for integrity due to the surjective nature of the function, and problem could arise due to being 'right-invertible'. This is a problem, if I am understanding correctly, since we could recover using a pre-image ... unsure of implications here EDIT: Probably only the case with deterministic viewkeys.

5.) Pending-tx-specific hash needs stored for database retrieval of the ptx_blob. Added a function in notary_server.cpp to calculate the hash and pair it with the ptx_blob. Rest of functions in flow from wallet -> rpc -> core -> blockchain -> db need modified to pass the hash through with the blob. Done: Oct 31

6.)Bring README.md up to speed (Mostly Done: 3 Nov), and add code flow document, for easier comprehension. Should go a long way in making things easier for those in KMD/ZEC ecosystem, in particular.

7.) Ensure that check against notary pubkeys also occurs daemon-side and not solely on wallet side. Need to look into further, but pretty sure that we currently lack verification in daemon. Maybe consider adding to blockchain as well.

@who-biz
Copy link
Contributor Author

who-biz commented Jan 23, 2020

Closing, and opening new with just code flow task

@who-biz who-biz closed this as completed Jan 23, 2020
@who-biz who-biz added the resolved dun been resolutioned label Jan 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
resolved dun been resolutioned
Projects
None yet
Development

No branches or pull requests

1 participant