Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

node render does not support custom images #9

Open
lordnynex opened this issue Sep 29, 2020 · 3 comments
Open

node render does not support custom images #9

lordnynex opened this issue Sep 29, 2020 · 3 comments

Comments

@lordnynex
Copy link

Small usability issue. I'm attempting to render a diagram that uses the GCP Pubsub icon (which the asset package does not appear to have).
pubsub

I thought I might be able to diagram.NewNode(diagram.Icon("pubsub.png")).Label("QueueName") but I noticed that node render expects the image path to be in the asset box. Would it be possible to fall back to local disk? Or maybe better yet provide a NodeOption like CustomImage to support custom icons?

@tntobias
Copy link
Collaborator

tntobias commented Oct 1, 2020

Good catch! We should absolutely find a way intuitively use images from outside the library. I have an idea on how to do this but wanna release an update before I tackle it. Thanks for calling attention to this.

@tntobias
Copy link
Collaborator

tntobias commented Oct 1, 2020

Also, the PubSub icon is under gcp.Analytics.Pubsub()

@Juandavi1
Copy link

hi, i have the same issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants