Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a replace_full method on IndexSet #222

Merged
merged 2 commits into from
Mar 29, 2022

Conversation

zakcutner
Copy link
Contributor

@zakcutner zakcutner commented Mar 27, 2022

  • Add a new replace_full method, which behaves like replace but also
    returns the index of the item.

  • Clarify that replace and replace_all do not modify the replaced
    item's insertion order in the documentation.

  • Add test coverage for replace and replace_full by copying the
    existing tests for insert and insert_full.

Closes #221

* Add a new `replace_full` method, which behaves like `replace` but also
  returns the index of the item.

* Clarify that `replace` and `replace_all` do not modify the replaced
  item's insertion order in the documentation.

* Add test coverage for `replace` and `replace_full` by copying the
  existing tests for `insert` and `insert_full`.
Copy link
Member

@cuviper cuviper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

I'll go ahead with a release bump in this PR too...

@cuviper cuviper merged commit 275379c into indexmap-rs:master Mar 29, 2022
@zakcutner zakcutner deleted the replace-full branch March 29, 2022 23:29
@zakcutner
Copy link
Contributor Author

Great, thanks so much!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement a replace_full method on IndexSet
2 participants