Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

closureLanguageOut ECMASCRIPT5 should not enforce STRICT mode #19

Closed
blutorange opened this issue Oct 14, 2018 · 7 comments
Closed

closureLanguageOut ECMASCRIPT5 should not enforce STRICT mode #19

blutorange opened this issue Oct 14, 2018 · 7 comments
Labels
bug Something isn't working closure compiler issue Issues or bugs that are caused by closure compiler itself, not this maven plugin.

Comments

@blutorange
Copy link
Owner

Issue by ph3n0m666
Tuesday Mar 21, 2017 at 10:31 GMT
Originally opened as samaxes#138


It seems, using 1.7.6 specifying ECMASCRIPT5 in closureLanguageIn/closureLanguageOut, is returning the following

object literals cannot contain duplicate keys in ES5 strict mode - but I am not specifying ECMASCRIPT5_STRICT - only ECMASCRIPT5

@blutorange
Copy link
Owner Author

Comment by cqxxxxxxxx
Tuesday May 09, 2017 at 13:43 GMT


this cames to me too. how you fix this?

@blutorange
Copy link
Owner Author

Comment by ph3n0m666
Tuesday May 09, 2017 at 13:57 GMT


Have not been able to fix this yet, still an open issue for me

@blutorange
Copy link
Owner Author

Comment by rtomsick
Tuesday Jun 26, 2018 at 18:14 GMT


Still there, still a bug.

This project is pretty much abandoned, right?

@blutorange
Copy link
Owner Author

This is a wrapper for closure compiler. This seems to be an issue with closure compiler itself. I can reproduce with the command line of closure compiler, even when disabling errors:

java -jar closure-compiler-v20181008.jar --language_in ECMASCRIPT_2016 --language_out ECMASCRIPT3 /tmp/test.js --jscomp_off es5Strict

@blutorange blutorange added the bug Something isn't working label Oct 14, 2018
@blutorange blutorange changed the title closureLanguageIn/closureLanguageOut set to ECMASCRIPT5 closureLanguageOut ECMASCRIPT5 should not enforce STRICT mode Oct 16, 2018
@blutorange blutorange added the closure compiler issue Issues or bugs that are caused by closure compiler itself, not this maven plugin. label Mar 3, 2019
@nitehawk42
Copy link

Is there a non-abandoned maven plugin project for closure-compiler?

@blutorange
Copy link
Owner Author

@nitehawk42 What do you mean? I'm still working on this plugin, although currently there's not much more to do than ocassionally updating closure compiler to the latest version. If there's a new closure compiler you need quickly, feel free to tell me and I can release a new version of this plugin. As for this issue, I kept it open, but the behavior is how closure compiler works.

@blutorange
Copy link
Owner Author

Closing as this is an issue of closure compiler itself (which may or may not have been changed in the recent version of closure compiler).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working closure compiler issue Issues or bugs that are caused by closure compiler itself, not this maven plugin.
Projects
None yet
Development

No branches or pull requests

2 participants