Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename INIT parameter #10

Closed
bluurryy opened this issue Apr 22, 2024 · 1 comment · Fixed by #11
Closed

Rename INIT parameter #10

bluurryy opened this issue Apr 22, 2024 · 1 comment · Fixed by #11
Labels
enhancement New feature or request

Comments

@bluurryy
Copy link
Owner

"INIT" is not a great name for what it represents.

In the standard library "init" / "uninit" are used exclusively for talking about uninitialized memory. This is not what it means in bump-scope, so thats confusing.

Maybe ALLOCATED, Bump::unallocated, into_allocated and as_allocated?

Perhaps use a more descriptive name like MAYBE_UNALLOCATED which would be !INIT?
@bluurryy bluurryy added the enhancement New feature or request label Apr 22, 2024
@bluurryy
Copy link
Owner Author

Or instead GUARANTEED_ALLOCATED?

@bluurryy bluurryy mentioned this issue Apr 22, 2024
Merged
@bluurryy bluurryy linked a pull request Apr 22, 2024 that will close this issue
Rename INIT to GUARANTEED_ALLOCATED, stats refactor #11
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Rename INIT to GUARANTEED_ALLOCATED, stats refactor bluurryy/bump-scope
1 participant
@bluurryy