Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resetprop is outdated #163

Closed
4 of 5 tasks
Pat-JK opened this issue Jan 18, 2024 · 2 comments · Fixed by #175
Closed
4 of 5 tasks

Resetprop is outdated #163

Pat-JK opened this issue Jan 18, 2024 · 2 comments · Fixed by #175

Comments

@Pat-JK
Copy link
Contributor

Pat-JK commented Jan 18, 2024

Please check before submitting an issue

  • I have searched the issues and haven't found anything relevant
  • If patch failed, root failed, or device unable to boot after flashing the new boot.img. Please goto KernelPatch
  • I will upload bugreport file in APatch Manager - Settings - Report log
  • My problem is fully stated in English, no reference to outside forums
  • I know how to reproduce the issue which may not be specific to my device

Describe the bug

The latest version of the Play Integrity Fork module by osm0sis fails to work as resetprop is missing the -Z argument.

To Reproduce

1: Open a terminal as root
2: Attempt to use resetprop with -Z argument, (example: resetprop -Z ro.boot.flash.locked 1)
3: Will display help information instead of running the proper command

Expected behavior

Command should run as expected

Screenshots

No response

Logs

No response

Device info

  • Device: Motorola One 5g Ace
  • OS Version: 13
  • APatch Version: 10450
  • Kernel Version: 4.19.157

Additional context

No response

@osm0sis
Copy link

osm0sis commented Jan 18, 2024

Some further context.

resetprop -Z was added to Magisk about 8 months ago (before v26.2), and the latest Magisk stable was 2 months ago (v26.4) in late November:
topjohnwu/Magisk@f36b21b

KernelSU updated to latest resetprop from Magisk Canary 26404 about 2 weeks ago:
tiann/KernelSU@153ce9a

Looks like resetprop was just missed for APatch when you did your binary updates as well to 26404 about 2 weeks ago:
e85fe75
https://github.com/bmax121/APatch/tree/main/app/libs/arm64-v8a

So yeah, please do update so all the prominent root solutions are in sync! You can probably just grab the standalone build from that KSU commit even. 🙂

@sekaiacg
Copy link
Contributor

Example from ksu: tiann/KernelSU@153ce9a

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants