Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

obsolete module #14

Open
Nilsonfsilva opened this issue Dec 30, 2023 · 1 comment
Open

obsolete module #14

Nilsonfsilva opened this issue Dec 30, 2023 · 1 comment

Comments

@Nilsonfsilva
Copy link

Hi!
I'm a maintainer of your project on Debian!
Recently presets had an error during construction.
The 'imp' module has been discontinued since Python version 3.4.

I applied this patch to solve the problem. If you want to incorporate it in the next version.

Big thanks!

Index: presets/setup.py

--- presets.orig/setup.py
+++ presets/setup.py
@@ -1,8 +1,11 @@
from setuptools import setup, find_packages

-import imp
+from importlib.machinery import SourceFileLoader

-version = imp.load_source('presets.version', 'presets/version.py')
+version = SourceFileLoader('presets.version', 'presets/version.py').load_module()
+
+#import imp
+#version = imp.load_source('presets.version', 'presets/version.py')

setup(
name='presets',

@bmcfee
Copy link
Owner

bmcfee commented Jan 14, 2024

Hi Nilson,

Thanks for the patch suggestion. Unfortunately, I don't think this will work as a patch since it would break the minimim supported python version specified in the package metadata. Would you be able to revise this as a pull request that we can test properly?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants