New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
long window mode for signals with sr <= 210Hz #14
base: master
Are you sure you want to change the base?
Conversation
Interesting -- looks like the tests are bombing out though. Any idea what's up with that? BTW, @jongwook, is this also an issue in your fork? |
I am traveling, but let me try in the next 24 hours or so. I never knew that there can be WAV files with <210Hz sample rate.. |
I took a quick look at sr=1523; num_samples=3000; freq=500; n_step=0.5
y = synth(sr, num_samples, freq)
y_s = pyrubberband.pitch_shift(y, sr, n_step)
len(y_s) returns |
This is starting to sound like something amiss in rubberband itself, and not pyrb? |
I'd agree with that assessment. Does anyone know what rubberband is using under the hood? Some PSOLA variant or a phase vocoder? |
It's open-source: https://bitbucket.org/breakfastquay/rubberband/ but the documentation/comments are a bit thin. I don't have the bandwidth to pick it apart right now. |
I should probably also add a link the issue this PR was meant to address #13 |
It hangs with the Cython version as well,
I am also seeing that |
Pyrubberband will hang when faced with low-sr signals unless the
--window-long
flag is set. This PR adds that flag for signals below 210Hz and allows the process to complete.