Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Type-checking #60

Closed
mindplay-dk opened this issue Jan 18, 2018 · 1 comment
Closed

Type-checking #60

mindplay-dk opened this issue Jan 18, 2018 · 1 comment

Comments

@mindplay-dk
Copy link

Looks like you have everything required in the model for performing various code validations, such as type-checking arguments. (Likely, type-inference and scope-based variable type annotations is the main thing missing to support work in that direction.)

Any plans to perform code validations eventually?

Or is that outside the scope of this project?

I realize there are plenty of options for static analysis, but most of the components that do the heavy lifting are very similar to what you've implemented - and none of them were designed as IDE tools, from the top-down with real-time performance in mind.

If we had a framework for this, I'd be happy to help with the actual inspections, so I could finally ditch the PHP storm bug nest and go all-in on VS Code ;-)

@bmewburn
Copy link
Owner

That's the plan. Code validation will be provided by the diagnostics provider. Currently it just reports parse errors. I haven't done much work on this as I'm considering moving to a representation of the syntax tree that is easier to work with (ast instead of parse tree), plus there are improvements to the type inference to be made in cases where phpdoc and type hints are not available for function return type. Any help would be appreciated :)
I'll close this in favour of bmewburn/intelephense#16

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants