Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fails to build with haskell-src-exts 1.21.0. #85

Open
galenhuntington opened this issue Dec 9, 2018 · 3 comments · May be fixed by #86
Open

Fails to build with haskell-src-exts 1.21.0. #85

galenhuntington opened this issue Dec 9, 2018 · 3 comments · May be fixed by #86

Comments

@galenhuntington
Copy link

The commit haskell-suite/haskell-src-exts@cc31887 replaced the data Kind l declaration, making instead Kind a synonym for Type. As a result, Language/Haskell/Meta/Syntax/Translate.hs fails to compile with the current haskell-src-exts, starting at this instance declaration:

instance ToType (Hs.Kind l) where

This stuff is a bit over my head, so I'm not sure how to fix it. Maybe this instance is no longer needed at all?

@galenhuntington
Copy link
Author

I encountered this because I had to build a downstream package with --allow-newer, so the < 1.21 bound didn't apply during installation. So, most people won't run into this conflict immediately, but presumably the code will need to be updated eventually.

@DanBurton
Copy link

Bump. Would appreciate if haskell-src-meta could upgrade to be compatible with the new haskell-src-exts.

@galenhuntington galenhuntington linked a pull request Dec 24, 2018 that will close this issue
@galenhuntington
Copy link
Author

I submitted a proposed solution in #86.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants