Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

compiler.js broken if this.options.basedir is undefined #151

Closed
nemophrost opened this issue Mar 13, 2013 · 3 comments
Closed

compiler.js broken if this.options.basedir is undefined #151

nemophrost opened this issue Mar 13, 2013 · 3 comments
Assignees

Comments

@nemophrost
Copy link

Line 41 of compiler.js causes an error if you haven't set this.options.baseDir. Not sure if this is a new bug introduced with the latest release of Node.

I change the line (as a temporary fix) to:
this.options.basedir = this.options.basedir ? path.resolve(this.options.basedir) : process.cwd();

@ghost ghost assigned bminer Mar 13, 2013
@nemophrost
Copy link
Author

Note: This was specifically encountered when using blade.renderFile()

@bminer
Copy link
Owner

bminer commented Mar 13, 2013

Confirmed. This was changed with the release of Node 0.10.0.
nodejs/node-v0.x-archive@089ec58

I will push a fix out right away.

@bminer bminer closed this as completed in 5021a13 Mar 13, 2013
@bminer
Copy link
Owner

bminer commented Mar 13, 2013

Thanks for the bug report!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants