Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filter Allowed Characters Undocumented #209

Closed
CodeLenny opened this issue Feb 13, 2017 · 2 comments
Closed

Filter Allowed Characters Undocumented #209

CodeLenny opened this issue Feb 13, 2017 · 2 comments

Comments

@CodeLenny
Copy link
Contributor

I found out that filters can't include $ the hard way.

:$my-filter
  test

I would think that filter names could contain a larger subset of characters, but perhaps there's some other limitation I'm not aware of.

Either way, it would be nice if the documentation might describe the allowed characters. It appears the parser is limited to:

first_char: [a-zA-Z_]
next_chars: [a-zA-Z0-9_:-]*
@bminer
Copy link
Owner

bminer commented Feb 14, 2017

I could change the parser to allow dollar sign $ in the identifier name. I am hesitant to add it to the parser because the identifier lexer rule is used for tag names, class names, attribute names, etc. Not sure how : colon made the cut either... come to think of it.

But... at the same time, I can't really argue much against it. It probably won't break anything, so I'll just go ahead and add it for now.

@CodeLenny
Copy link
Contributor Author

@bminer Thanks!

@bminer bminer closed this as completed in ab5ca14 May 9, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants