Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compile to ES5 #5

Closed
kerrickwoyshner opened this issue Jun 30, 2018 · 1 comment
Closed

Compile to ES5 #5

kerrickwoyshner opened this issue Jun 30, 2018 · 1 comment
Assignees

Comments

@kerrickwoyshner
Copy link

React's automatic build script does not work because this project does not provide ES5 code.

See https://github.com/facebook/create-react-app/blob/master/packages/react-scripts/template/README.md#npm-run-build-fails-to-minify

Also, providing ES5 support will make this work on IE 10/11.

@bminer bminer self-assigned this Jul 5, 2018
@bminer bminer closed this as completed in b91c3f0 Jul 5, 2018
@bminer
Copy link
Owner

bminer commented Mar 7, 2019

It should be noted that this has been fixed in react-scripts@2

https://facebook.github.io/create-react-app/docs/troubleshooting#npm-run-build-fails-to-minify

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants