New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Publish 0.3.x python wheels for Linux/non-macOS platforms #14
Comments
Great catch! Was an oversight on my part, I'll see if I can do a quick release to fix it. In the meantime, you can use the latest wheels built from master (they are built for manylinux1). |
Ah, great, didn't see those :) I think maturin is packing them under a different package name than you are intending to, though? After installing the wheel, no module |
It's complicated. You can't easily change the wheel name with maturin (see PyO3/maturin#313), and I can't use "nnsplit" because that would clash with the nnsplit core Rust module. In the release script I use a hacky workaround: https://github.com/bminixhofer/nnsplit/blob/3baaa15be23f68fd83237eefdc910b1a0b4de6c2/release.sh#L25-L31 but I didn't yet bother for the nightly wheels. |
Just to clarify: Are you saying it should work with the workaround that's not yet in the nightly wheels, or should it already be working with the current nightly wheels? Because right now I get (after a successful install of the wheel):
|
It should already work. Are you sure you're using the same Python interpreter? I just tried this on my machine with a new venv:
|
You are right. Looks like I wasn't using the my poetry venv 🙄 Works well now! :) |
Great! Let me know if you have any more issues. |
This is a bit more complicated than I thought, I'll have to move the release script to CI. But will be done soon. |
After lots of blood, sweat and tears this is now working 😉. Windows, Linux and MacOS wheels are built, tested and released in CI as of v0.4.9. Only caveat is that the Python version is x-post0 for any version x. That was the only way to avoid version clashes while building the Python bindings if they're called FYI, I'll remove the nightly build now, it's mostly obsolete now and just spams notifications. |
After running into #13, I tried to use the Python bindings instead. It worked, but I noticed that installed version
0.2.2
(saw it didn't match up with the documentation in the README).After digging into it a little bit, I saw that
0.2.2
was the last release with a platform-agnostic wheel available. All 0.3.x wheels seem to be built specifically for macOS, and are not installable on my Linux/Ubuntu machine.I'm wondering if there are some easy adjustments that could be made to make publishing wheels for all platforms again possible (or at least Linux/Ubuntu 😇 )?
The text was updated successfully, but these errors were encountered: