Skip to content
This repository has been archived by the owner on Jan 26, 2022. It is now read-only.

Consider compiling permon #5

Open
bminixhofer opened this issue Oct 14, 2018 · 1 comment
Open

Consider compiling permon #5

bminixhofer opened this issue Oct 14, 2018 · 1 comment
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@bminixhofer
Copy link
Owner

permon could be compiled using pyqtdeploy or pyinstaller.
pyqtdeploy looks like the better choice if we stay with Qt in the native frontend because you can manually include all needed parts of PyQt with it. PyInstaller would package the whole PyQt package.

At the moment, the user needs to have Python 3 installed, and needs a couple of python modules. PySide2, for example, is over 100MB large.
It would definitely be good if we could package those. It would also probably bring a performance improvement.
The problem is that that would make the user not able to add custom stats anymore. That is an important feature so the next step is investigating if it is possible to compile a python module but still import .py files from it without recompiling.

@bminixhofer bminixhofer added the enhancement New feature or request label Oct 14, 2018
@bminixhofer bminixhofer self-assigned this Oct 14, 2018
@bminixhofer bminixhofer added this to To do in v2.0 Oct 14, 2018
@bminixhofer
Copy link
Owner Author

This issue is (more or less) solved by only listing generally needed packages as the requirements for pip. The user is then prompted to install frontend-specific packages once he launches that frontend for the first time.
The points I originally made in this issue are however still valid so I will keep this issue open for discussion.

@bminixhofer bminixhofer added the help wanted Extra attention is needed label Dec 4, 2018
@bminixhofer bminixhofer removed this from To do in v2.0 Dec 4, 2018
@bminixhofer bminixhofer removed their assignment Dec 4, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

1 participant