Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider all emojis when deciding what emoji to use for a config #394

Open
bmish opened this issue Jan 18, 2023 · 0 comments
Open

Consider all emojis when deciding what emoji to use for a config #394

bmish opened this issue Jan 18, 2023 · 0 comments
Labels
Milestone

Comments

@bmish
Copy link
Owner

bmish commented Jan 18, 2023

We currently have a list of default emojis for common config names:

const EMOJI_A11Y = '♿';
const EMOJI_ERROR = '❗';
const EMOJI_STYLE = '🎨';
const EMOJI_TYPESCRIPT = '⌨️';
const EMOJI_WARNING = '🚸';
/** Default emojis for common configs. */
export const EMOJI_CONFIGS = {
a11y: EMOJI_A11Y,
accessibility: EMOJI_A11Y,
all: '🌐',
error: EMOJI_ERROR,
errors: EMOJI_ERROR,
recommended: '✅',
strict: '🔒',
style: EMOJI_STYLE,
stylistic: EMOJI_STYLE,
ts: EMOJI_TYPESCRIPT,
type: EMOJI_TYPESCRIPT,
typed: EMOJI_TYPESCRIPT,
types: EMOJI_TYPESCRIPT,
typescript: EMOJI_TYPESCRIPT,
warning: EMOJI_WARNING,
warnings: EMOJI_WARNING,
};

If none of those curated emojis match the config name, we could fallback to checking for any other match in a complete dictionary of emojis based on the standard keywords associated with each emoji.

Potential libraries to help with finding the best emoji for a given config name:

Note that the user can always use to the --config-emoji option to change or remove the auto-assigned emoji.

Separately, we could also add some more default emojis, for things like common frontend frameworks.

@bmish bmish added the breaking label Jan 18, 2023
@bmish bmish added this to the v2.0.0 milestone Jan 18, 2023
@bmish bmish changed the title Consider full list of emojis when deciding what emoji to use for a config Consider all emojis when deciding what emoji to use for a config Jan 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant