Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecated: Return type of RequirementCollection::getIterator() #344

Closed
beeyev opened this issue Feb 2, 2022 · 3 comments
Closed

Deprecated: Return type of RequirementCollection::getIterator() #344

beeyev opened this issue Feb 2, 2022 · 3 comments
Labels

Comments

@beeyev
Copy link

beeyev commented Feb 2, 2022

Hello, first of all, thanks for the great tool, I have been using it for quite a long time.
But it seems that the library needs to be updated in order to work with PHP 8.1
I get these errors:

Deprecated: Return type of HumbugBox391\KevinGH\RequirementChecker\RequirementCollection::getIterator() should either be compatible with IteratorAggregate::getIterator(): Traversable, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice in phar:///usr/local/bin/churn/.box/src/RequirementCollection.php on line 15

Deprecated: Return type of HumbugBox391\KevinGH\RequirementChecker\RequirementCollection::count() should either be compatible with Countable::count(): int, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice in phar:///usr/local/bin/churn/.box/src/RequirementCollection.php on line 19
Deprecated: Return type of Symfony\Component\Console\Helper\HelperSet::getIterator() should either be compatible with IteratorAggregate::getIterator(): Traversable, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice in phar:///usr/local/bin/churn/vendor/symfony/console/Helper/HelperSet.php on line 104

Could you please fix that.

@villfa villfa added the bug label Feb 2, 2022
@villfa
Copy link
Collaborator

villfa commented Feb 2, 2022

Thank you for your report.

I'm able to reproduce the problem when I run churn.phar in a PHP 8.1 environment.
I'll find a way to fix this soon.

@villfa
Copy link
Collaborator

villfa commented Feb 3, 2022

The upcoming release (1.6.0) will contain the fix for this issue.

@villfa villfa closed this as completed Feb 3, 2022
@villfa
Copy link
Collaborator

villfa commented Feb 3, 2022

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants