Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

README example in Python3.5 references Python2.x code. #27

Closed
danielquinn opened this issue Jun 10, 2017 · 3 comments
Closed

README example in Python3.5 references Python2.x code. #27

danielquinn opened this issue Jun 10, 2017 · 3 comments

Comments

@danielquinn
Copy link

danielquinn commented Jun 10, 2017

The setup.py for this project's python3.5 branch had one reference to rpcudp>=3.0.0 which isn't in pypi, so things explode when you try to install it. I'm not sure if there's anything that can be done about that so long as you don't feel rpcudp is ready for prime time though:

Could not find a version that satisfies the requirement rpcudp>=3.0.0 (from kademlia) (from versions: 0.1, 0.2, 0.3, 0.4, 1.0, 2.0, 2.1)
No matching distribution found for rpcudp>=3.0.0 (from kademlia)

However, kademilia also doesn't cite a dependency on twisted (though the master branch does). This was a surprise when I was trying things out so I thought it worth mentioning as that's definitely a stable package you can reference in setup.py.

@danielquinn
Copy link
Author

Wait a sec, I see what's happening, I'm using the example from the README, but that not updated in the Python3.5 branch, so it's still referencing Twisted. After a grepping of the codebase, twisted isn't used for the 3.5 branch -- I get it now.

Well then I guess I'll rename this issue to something more relevant.

@danielquinn danielquinn changed the title Installation of Python3.5 has broken dependencies README example in Python3.5 references Python2.x code. Jun 10, 2017
@bmuller
Copy link
Owner

bmuller commented Jun 10, 2017

Yep! Other than updating the code to work with Python 3 and stripping out Twisted, I didn't update the README/docs/examples/etc.

@bmuller
Copy link
Owner

bmuller commented Jan 9, 2019

This is all updated. Thanks!

@bmuller bmuller closed this as completed Jan 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants