Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

load_state does not await bootstrap #78

Closed
JohnDoee opened this issue Feb 21, 2020 · 1 comment
Closed

load_state does not await bootstrap #78

JohnDoee opened this issue Feb 21, 2020 · 1 comment

Comments

@JohnDoee
Copy link
Contributor

Describe the bug
When trying to load_state, the bootstrap promise is never awaited and therefore the function won't work. https://github.com/bmuller/kademlia/blob/master/kademlia/network.py#L224

This brings up a bit of weirdness for me because I don't find it smart to save state that way. My solution was to save the whole routing table.

@bmuller
Copy link
Owner

bmuller commented Feb 21, 2020

Thanks @JohnDoee - another great catch.

Btw - just loading the bootstrappable neighbors should be sufficient to rebuild the routing table (with up to date routes - it's possible many nodes you knew about before are no longer active/up).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants