Skip to content
This repository has been archived by the owner on Sep 16, 2022. It is now read-only.

gae backend tasks should use exploded war folder #18

Closed
musketyr opened this issue Apr 18, 2012 · 12 comments
Closed

gae backend tasks should use exploded war folder #18

musketyr opened this issue Apr 18, 2012 · 12 comments
Assignees
Milestone

Comments

@musketyr
Copy link
Contributor

instead of web app source directory

@ghost ghost assigned bmuschko Apr 27, 2012
@bmuschko
Copy link
Owner

Do you consider this to be a bug? I guess from the documentation I couldn't quite figure out whether <dir> is the web application directory or the WAR directory.

@musketyr
Copy link
Contributor Author

well, the problem is that I to point to the same dir as gaeUpload does. if it points to source dir it just uploads the web app without classes/libs causing ClassNotFoundException

@bmuschko
Copy link
Owner

I put a fix in place on this branch for the backends update tasks. These tasks now depend on gaeUpload and will use the exploded WAR directory in the command (see commit). Can you give it a try and let me know if that fixes your problem? I was also wondering if the other backends tasks work as expected?

@musketyr
Copy link
Contributor Author

cool thanks. I'll check it probably this weekend or next week. I've got some deadlines this week.

@musketyr
Copy link
Contributor Author

works excellent. could you also add gaeUploadAll task which will depend on gaeUpload and gaeUploadAllBackends. these two are often used together.

would you mind if I publish gae gradle plugin and gaelyk gradle plugin on maven central under org.gaelyk group id?

@bmuschko
Copy link
Owner

Sure thing. Will add the task.

I was always hesitant to upload the Gradle plugins to Maven as I was waiting for Gradleware to provide a custom plugin repository. But yeah...I can do that for sure.

@musketyr
Copy link
Contributor Author

Cool.

As Gradle Roadmap says 'Discussions are happening and work will start not long after the release of 1.0' about plugin repository we could wait a year or so until it's done.

@musketyr
Copy link
Contributor Author

so, should I publish it using 'org.gaelyk' or will you do it under your group id?

@bmuschko
Copy link
Owner

I will need to add the task and configuration for uploading it to Maven Central first. I am going to publish it under a different group ID than org.gaelyk as it actually is not Gaelyk-specific. Any Java project using Google App Engine can use it.

@bmuschko
Copy link
Owner

I added the task gaeUploadAll as well. Give it a spin and let me know. If it works as expected I will release a new plugin version and upload it to Maven Central.

@musketyr
Copy link
Contributor Author

thanks, it works well.

@bmuschko
Copy link
Owner

I released a new version of the plugin and created a separate issue for uploading it to Maven Central.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants