Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Performance issues in training_api/research/ (by P3) #39

Closed
DLPerf opened this issue Aug 22, 2021 · 2 comments
Closed

Performance issues in training_api/research/ (by P3) #39

DLPerf opened this issue Aug 22, 2021 · 2 comments

Comments

@DLPerf
Copy link

DLPerf commented Aug 22, 2021

Hello! I've found a performance issue in your program:

  • tf.Session being defined repeatedly leads to incremental overhead.

You can make your program more efficient by fixing this bug. Here is the Stack Overflow post to support it.

Below is detailed description about tf.Session being defined repeatedly:

  • in object_detection/eval_util.py: sess = tf.Session(master, graph=tf.get_default_graph())(line 273) is defined in the function _run_checkpoint_once(line 211) which is repeatedly called in the loop while True:(line 431).
  • in slim/datasets/download_and_convert_cifar10.py: with tf.Session('') as sess:(line 91) is defined in the function _add_to_tfrecord(line 64) which is repeatedly called in the loop for i in range(_NUM_TRAIN_FILES):(line 184).

tf.Session being defined repeatedly could lead to incremental overhead. If you define tf.Session out of the loop and pass tf.Session as a parameter to the loop, your program would be much more efficient.

Looking forward to your reply. Btw, I am very glad to create a PR to fix it if you are too busy.

@DLPerf
Copy link
Author

DLPerf commented Nov 4, 2021

Hello, I'm looking forward to your reply~

@hadikoub
Copy link
Member

hadikoub commented Mar 2, 2022

Hello Sorry for the late reply,
We've updated our GUI including functional and visual changes; But most importantly we are now using Tensorflow Object Detection API V2. We base our training and evaluation workflow on provided functionalities in TF2 OB. that contains various enhancement.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants