[sentry_lumberdash] Support latest sentry version and add tests #75
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #75 +/- ##
===========================================
+ Coverage 36.45% 48.45% +11.99%
===========================================
Files 6 6
Lines 96 97 +1
===========================================
+ Hits 35 47 +12
+ Misses 61 50 -11
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
ueman
changed the title
HubAdapter forwards to Sentrys static API. This makes it more resilient. This way you could init lumberdash before Sentry or after Sentry. This doesn't work with Sentry.currentHub. CurrentHub is a NoOp Hub until Sentry is initialized. This means you couldn't even init lumberdash inside Sentrys initApp callback.
|
Docker pull failed but the build should be green if you restart it. Instead of docker you could also use the GitHub Dart Action: https://github.com/dart-lang/setup-dart |
|
@fabiomcarneiro or @fwagner do you mind taking a look at this? |
fwagner
approved these changes
Apr 7, 2021
|
Thanks @ueman. New version is available on pub.dev: https://pub.dev/packages/sentry_lumberdash/versions/3.1.0. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates sentry_lumberdash to the latest Sentry version.
I also added tests and it should now have complete coverage.
I've also improved the documentation and various links.