Update Sentry in SentryLumberdash #78
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #78 +/- ##
==========================================
+ Coverage 41.17% 48.45% +7.27%
==========================================
Files 5 6 +1
Lines 85 97 +12
==========================================
+ Hits 35 47 +12
Misses 50 50
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
ueman
commented
Jul 22, 2021
| @@ -15,8 +15,7 @@ environment: | |||
| dependencies: | |||
| lumberdash: ^3.0.0 | |||
| meta: ^1.3.0 | |||
| sentry: ^5.0.0 | |||
| sentry: ^6.0.0-0 | |||
There was a problem hiding this comment.
This makes it compatible with the current Sentry beta up to but exclusive version 7.x.x.
|
|
||
| dev_dependencies: | ||
| test: ^1.16.5 | ||
| mockito: ^5.0.0 |
There was a problem hiding this comment.
Mockito isn't used anymore
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates Sentry to version 6 which is currently in beta.
The parts of Sentry which are used in this project are stable and there aren't any planned breaking changes left (I'm one of the maintainers).
So this should be safe to publish. However, I'll leave it up to you if you want to do that.
cc @fwagner @fabiomcarneiro