Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Determine minimal supported rust version #6

Closed
bmwill opened this issue Jul 3, 2020 · 2 comments
Closed

Determine minimal supported rust version #6

bmwill opened this issue Jul 3, 2020 · 2 comments

Comments

@bmwill
Copy link
Owner

bmwill commented Jul 3, 2020

#4 identified that the use of the matches! macro pushed the msrv to 1.42. Once that PR is landed determine what the new msrv is (or should be) and add a check in CI.

@weiznich
Copy link
Contributor

weiznich commented Jul 3, 2020

For diesel we use this ci snippet to verify that we do not accidentally bump our minimal supported rust version.
Generally speaking: It's just fine to choose whatever version you want there. It's just that the fix was easy and that would allow us to keep supporting that version with diesel 😉

@bmwill
Copy link
Owner Author

bmwill commented Jul 7, 2020

Current minimum supported rust version is 1.36.0 as of 6453d35.

@bmwill bmwill closed this as completed Jul 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants