Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

investigate memory machinery optimisation with prepack/closure compiler #83

Closed
Bnaya opened this issue May 2, 2020 · 2 comments
Closed
Assignees
Labels
enhancement New feature or request

Comments

@Bnaya
Copy link
Owner

Bnaya commented May 2, 2020

https://github.com/Bnaya/objectbuffer/blob/develop/src/internal/memoryMachinery.ts

The memoryMachinery stuff adding few layers of indirection on top of typedArray to provide something that is similar to C structs

Most of these indirections can be replaced with flat code, that probably gonna be more performant.

prepack / closure compiler might we able to reduce some of the indirections, maybe after some changes

@Bnaya Bnaya added the enhancement New feature or request label May 2, 2020
@Bnaya Bnaya self-assigned this May 23, 2020
@Bnaya
Copy link
Owner Author

Bnaya commented May 23, 2020

#86 + the terser minify inline the structs access very nicely,
But there are other things we can achieve from better inlining
This issue is absolute, need to open more up to date one

@Bnaya
Copy link
Owner Author

Bnaya commented May 29, 2020

Mostly inlined

@Bnaya Bnaya closed this as completed May 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant