Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[R4R] state verification pipeline #795

Merged
merged 30 commits into from Mar 28, 2022
Merged

[R4R] state verification pipeline #795

merged 30 commits into from Mar 28, 2022

Conversation

forcodedancing
Copy link
Contributor

@forcodedancing forcodedancing commented Mar 14, 2022 •
edited

Description

Improve the performance of block importing by pipelining state verification, which consumes a big portion of time of block importing.

Rationale

In the previous release, the pipecommit feature is well implemented. Following the pipecommit feature, the pr tries to further pipeline state verification, by moving AccountsIntermediateRoot from ValidateState function to Commit function.

Workflow

svp_workflow

  1. Commit Snapshot will not wait for AccountsIntermediateRoot (thereby the new snapshot data is not correct)
  2. Before Commit Snapshot, needed accounts will be populated
  3. After AccountsIntermediateRoot, the snapshot generated will be corrected

Performance

Instances with 8 cores, 64G memory, 2.5T SSD (S1 vs S3)

Importing Time （0.75 quantile)

Before SVP
image
After SVP (S1 is using SVP)
image

State Verification Percentage

S3
image
S1 (S1 is using SVP)
image

Instances with 16 cores, 64G memory, 7.5T NVME (155 vs 118)

Importing Time （0.75 quantile)

Before SVP
image
After SVP (155 is using SVP)
image

State Verification Percentage

118
image
115 (155 is using SVP)
image

In general, the performance improvement effect is different on different instance types and different transaction volumes; if there is more time spent on state verification, then the improvement will be more obvious.

Changes

Notable changes:

  • ValidateState, Commit function are changed to support state verification pipeline

forcodedancing
forcodedancing commented Mar 14, 2022
View reviewed changes
core/state/statedb.go Outdated Show resolved Hide resolved
forcodedancing
forcodedancing commented Mar 15, 2022
View reviewed changes
core/blockchain.go Outdated Show resolved Hide resolved
forcodedancing
forcodedancing commented Mar 15, 2022
View reviewed changes
core/state/statedb.go Outdated Show resolved Hide resolved
unclezoro
unclezoro reviewed Mar 16, 2022
View reviewed changes
core/state/statedb.go Outdated Show resolved Hide resolved
@bnb-chain bnb-chain deleted a comment from realuncle Mar 16, 2022
unclezoro
unclezoro reviewed Mar 16, 2022
View reviewed changes
core/state/statedb.go Outdated Show resolved Hide resolved
unclezoro
unclezoro reviewed Mar 16, 2022
View reviewed changes
core/state/statedb.go Outdated Show resolved Hide resolved
unclezoro
unclezoro reviewed Mar 16, 2022
View reviewed changes
core/state/statedb.go Outdated Show resolved Hide resolved
unclezoro
unclezoro reviewed Mar 16, 2022
View reviewed changes
core/state/statedb.go Outdated Show resolved Hide resolved
unclezoro
unclezoro reviewed Mar 16, 2022
View reviewed changes
core/state/statedb.go Outdated Show resolved Hide resolved
NashBC
NashBC reviewed Mar 18, 2022
View reviewed changes
core/state/statedb.go Outdated Show resolved Hide resolved
@unclezoro unclezoro changed the title [WIP] state verification pipeline [R4R] state verification pipeline Mar 24, 2022
realuncle
realuncle reviewed Mar 24, 2022
View reviewed changes
core/block_validator.go Outdated Show resolved Hide resolved
setunapo
setunapo approved these changes Mar 24, 2022
View reviewed changes
Copy link
Contributor

@setunapo setunapo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

unclezoro
unclezoro reviewed Mar 25, 2022
View reviewed changes
core/state/statedb.go Outdated Show resolved Hide resolved
@unclezoro
Copy link
Collaborator

Let us use a special hash instead of emptyRoot.

@unclezoro unclezoro merged commit 90dc3d2 into bnb-chain:develop Mar 28, 2022
unclezoro pushed a commit that referenced this pull request Mar 29, 2022
@forcodedancing @unclezoro
[R4R] state verification pipeline (#795)
d894987 
* pipeline state verification

* update codes and add logs for debug

* refactor

* update and add logs

* refactor

* refactor

* remove unneeded logs

* fix a blocking issue

* fix sync issue when force kill

* remove logs

* refactor based on comments

* refactor based on comments

* refactor based on comments

* refactor based on comments

* refactor based on comments

* fix a deadlock issue

* fix merkle root mismatch issue during sync

* refactor based on review comments

* remove unnecessary code

* remove unnecessary code

* refactor based on review comments

* change based on comments

* refactor

* uew dummyRoot to replace emptyRoot

* add nil check

* add comments

* remove unneeded codes

* format comments

Co-authored-by: forcodedancing <liguo.fudan@gmail.com>
This was referenced Apr 8, 2022
Merged
Merged
This was referenced May 25, 2022
Open
Closed
@setunapo setunapo mentioned this pull request Oct 1, 2022
Merged
This was referenced Oct 12, 2022
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@realuncle realuncle realuncle left review comments

@NashBC NashBC NashBC left review comments

@unclezoro unclezoro unclezoro approved these changes

@j75689 j75689 j75689 approved these changes

@setunapo setunapo setunapo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@forcodedancing @unclezoro @j75689 @realuncle @NashBC @setunapo