feat: update gvg save logic #1345
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
annielz
requested review from
ruojunm,
will-2012,
unclezoro and
KeefeL
as code owners
ruojunm
reviewed
Feb 5, 2024
| @@ -41,7 +41,18 @@ func (db *DB) SaveGVGToSQL(ctx context.Context, gvg *models.GlobalVirtualGroup) | |||
| } | |||
|
|
|||
| func (db *DB) UpdateGVGToSQL(ctx context.Context, gvg *models.GlobalVirtualGroup) (string, []interface{}) { | |||
| stat := db.Db.Session(&gorm.Session{DryRun: true}).Table((&models.GlobalVirtualGroup{}).TableName()).Where("global_virtual_group_id = ?", gvg.GlobalVirtualGroupId).Updates(gvg).Statement | |||
| stat := db.Db.Session(&gorm.Session{DryRun: true}).Table((&models.GlobalVirtualGroup{}).TableName()).Clauses(clause.OnConflict{ | |||
| Columns: []clause.Column{{Name: "global_virtual_group_id"}}, | |||
There was a problem hiding this comment.
please update or create corresponding UT
* feat: expect lvg case fail and other pass * feat: try2 * fix: gvg test * fix: 2 * feat: update lvg * fix: db * feat: try 3 * feat: add where to update * feat: update test with removed * feat: update tests * fix: lvg * fix: gvg * fix: delete gvg * feat: cleanup
constwz
approved these changes
Feb 19, 2024
BarryTong65
approved these changes
Feb 19, 2024
ruojunm
approved these changes
Feb 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Update gvg save logic to handle default values (0, nil etc.) to be saved into db.
Rationale
To make sure the gvg values are correctly saved in db.
Example
N/A
Changes
Notable changes:
Potential Impacts