Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add new msg MsgSetTag #526

Merged
merged 6 commits into from Dec 1, 2023
Merged

feat: add new msg MsgSetTag #526

merged 6 commits into from Dec 1, 2023

Conversation

Pythonberg1997
Copy link
Contributor

@Pythonberg1997 Pythonberg1997 commented Nov 20, 2023 •
edited by KeefeL

Description

This pr is to add a new msg type MsgSetTag

Rationale

To enable resource tagging

Example

N/A

Changes

Notable changes:

  • add new msg MsgSetTag
  • add new event EventSetTag

Potential Impacts

  • Block Syncer and explorer should support tag when indexing createBucket, createObject and createGroup
  • Explorer should support new transaction type MsgSetTags

unclezoro
unclezoro reviewed Nov 22, 2023
View reviewed changes
x/storage/types/keys.go Outdated Show resolved Hide resolved
@unclezoro unclezoro added this pull request to the merge queue Dec 1, 2023
Merged via the queue into bnb-chain:develop with commit 8ade598 Dec 1, 2023
5 checks passed
@Pythonberg1997 Pythonberg1997 deleted the eddystone branch December 4, 2023 02:56
@unclezoro unclezoro mentioned this pull request Dec 6, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@unclezoro unclezoro unclezoro approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Pythonberg1997 @unclezoro