Add webpack-cli and jest to project list #33
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@bnb Please review this. |
hemal7735
changed the title
bnb
reviewed
Nov 17, 2018
lib/projects.js
Outdated
| @@ -41,6 +41,10 @@ var projects = { | |||
| "webpack-cli": { | |||
| name: 'webpack-cli', | |||
There was a problem hiding this comment.
Since the module on npm uses "webpack CLI" let's use that 😄
Suggested change
| name: 'webpack-cli', | |
| name: 'webpack CLI', |
lib/projects.js
Outdated
| @@ -41,6 +41,10 @@ var projects = { | |||
| "webpack-cli": { | |||
| name: 'webpack-cli', | |||
| q: 'repo:webpack/webpack-cli is:open is:issue label:"Good First Contribution"' | |||
| }, | |||
| jest: { | |||
| name: 'jest', | |||
There was a problem hiding this comment.
Same goes for the Jest website, using "Jest" rather than the lower-case "jest".
Suggested change
| name: 'jest', | |
| name: 'Jest', |
|
Otherwise LGTM and this can be merged once those changes are made – thanks for the PR! 👍 |
|
@hemal7735 please rebase and resolve the conflicts |
|
LGTM! Thank you for the PR @hemal7735 💥 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.