Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

failing to build on node 11.0.0 #121

Closed
drewfish opened this issue Oct 30, 2018 · 1 comment
Closed

failing to build on node 11.0.0 #121

drewfish opened this issue Oct 30, 2018 · 1 comment

Comments

@drewfish
Copy link

I'm seeing the following errors:

  CXX(target) Release/obj.target/addon/src/heapdump.o
In file included from ../src/heapdump.cc:17:0:
../src/compat-inl.h: In static member function ‘static void compat::CpuProfiler::StartCpuProfiling(v8::Isolate*, v8::Local<v8::String>)’:
../src/compat-inl.h:300:19: error: ‘class v8::Isolate’ has no member named ‘GetCpuProfiler’; did you mean ‘GetHeapProfiler’?
   return isolate->GetCpuProfiler()->StartProfiling(title, record_samples);
                   ^~~~~~~~~~~~~~
../src/compat-inl.h:300:73: error: return-statement with a value, in function returning 'void' [-fpermissive]
   return isolate->GetCpuProfiler()->StartProfiling(title, record_samples);
                                                                         ^
../src/compat-inl.h: In static member function ‘static const v8::CpuProfile* compat::CpuProfiler::StopCpuProfiling(v8::Isolate*, v8::Local<v8::String>)’:
../src/compat-inl.h:310:19: error: ‘class v8::Isolate’ has no member named ‘GetCpuProfiler’; did you mean ‘GetHeapProfiler’?
   return isolate->GetCpuProfiler()->StopProfiling(title);
                   ^~~~~~~~~~~~~~
@bnoordhuis
Copy link
Owner

Fixed in v0.3.10.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants